Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for realm protocol param #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jbernardo95
Copy link

@jbernardo95 jbernardo95 commented Nov 14, 2021

This PR adds support for the realm protocol param as described in rfc5849.

It also contains a few unrelated/minor improvements.

Best reviewed commit by commit.

To improve test readability.
To improve test readability.
Adds test for functions that didn't have any tests.
This commit adds support for the realm protocol param as described in
rfc5849 (https://datatracker.ietf.org/doc/html/rfc5849).
@jbernardo95
Copy link
Author

@lexmag I'd appreciate a review from you when you have the chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant