Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved container class to layout #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bodrak
Copy link

@bodrak bodrak commented Dec 27, 2017

Moved the container class (bootstrap) into the layout template. It makes more sense for two reasons:

  1. Code optimization: As the 3 templates extending the layout (overview, new and grid) are adding this class, it is optimized to put it only on the layout template.
  2. For a better integration with backends, where there often is a sidebar on the left, the container class breaks near the breakpoints, and so we can more easily fix it by replacing this class by a container-fluid class by example.

Most of the changes are indents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant