Add missing timestamp properties to the File model #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks to point that out, but maybe we should just remove these pre-persist and pre-update hooks. The dates are not use in the current process, and if we add them to the Doctrine ORM mapping, we also need to map them for Doctrine ODM and Propel to be consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to add this bundle to a project, Doctrine was complaining that the
createdAtproperty does not exist on theFileentity.The pre-persist and pre-update hooks attempts to set
createdAtandupdatedAtto the current datetime, but these properties are not declared, nor are they mapped. The pull request fixes that.Note that I've made them nullable because surprisingly no-one has reported this as an issue yet, so I wanted to keep some backwards compatibility.