Skip to content

Commit

Permalink
Fix get_proc_stats's error related to different strings split in diff…
Browse files Browse the repository at this point in the history
…erent Perl versions. Update pgcenter-testing fixtures and image.
  • Loading branch information
lesovsky committed Jul 18, 2021
1 parent 9d19b16 commit 7ebd548
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/default.yml
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
test:
runs-on: ubuntu-latest
container: lesovsky/pgcenter-testing:v0.0.5
container: lesovsky/pgcenter-testing:0.0.6

steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
test:
runs-on: ubuntu-latest
container: lesovsky/pgcenter-testing:v0.0.5
container: lesovsky/pgcenter-testing:0.0.6

steps:
- name: Checkout code
Expand Down
5 changes: 4 additions & 1 deletion internal/query/pgcenter_schema.go
Expand Up @@ -47,7 +47,10 @@ while (<FILE>) {
# skip header if required.
if ($i < $_[3]) { $i++; next; }
chomp;
my @items = map {s/^\s+|\s+$//g; $_;} split ($_[1]);
# trim extra white-spaces
$_ =~ s/\s+/ /g;
$_ =~ s/^\s+|\s+$//g;
my @items = map { $_ } split ($_[1]);
my %iitems;
# use filter if required.
if ($items[0] =~ $_[2] && $_[2] ne "") {
Expand Down
36 changes: 36 additions & 0 deletions internal/query/pgcenter_schema_test.go
@@ -0,0 +1,36 @@
package query

import (
"fmt"
"github.com/lesovsky/pgcenter/internal/postgres"
"github.com/stretchr/testify/assert"
"testing"
)

func Test_QueryPgcenterSchema(t *testing.T) {
queries := []string{
"SELECT * FROM pgcenter.sys_proc_diskstats",
"SELECT * FROM pgcenter.sys_proc_loadavg",
"SELECT * FROM pgcenter.sys_proc_meminfo",
"SELECT * FROM pgcenter.sys_proc_netdev",
"SELECT * FROM pgcenter.sys_proc_stat",
"SELECT * FROM pgcenter.sys_proc_uptime",
"SELECT * FROM pgcenter.sys_proc_mounts",
}

versions := []int{90500, 90600, 100000, 110000, 120000, 130000, 140000}

for _, version := range versions {
t.Run(fmt.Sprintf("query-pgcenter-schema/%d", version), func(t *testing.T) {
conn, err := postgres.NewTestConnectVersion(version)
assert.NoError(t, err)

for _, q := range queries {
_, err = conn.Exec(q)
assert.NoError(t, err)
}

conn.Close()
})
}
}
4 changes: 2 additions & 2 deletions testing/Dockerfile
Expand Up @@ -11,7 +11,7 @@
# __release_tag__ gosec v2.6.1 was released 2021-01-22
FROM ubuntu:20.04

LABEL version="v0.0.5"
LABEL version="0.0.6"

ENV DEBIAN_FRONTEND=noninteractive

Expand Down Expand Up @@ -44,4 +44,4 @@ RUN apt-get update && \
COPY prepare-test-environment.sh /usr/local/bin/
COPY fixtures.sql /usr/local/testing/

CMD ["echo", "I'm pgcenter-testing v0.0.5"]
CMD ["echo", "I'm pgcenter-testing 0.0.6"]
5 changes: 4 additions & 1 deletion testing/fixtures.sql
Expand Up @@ -37,7 +37,10 @@ while (<FILE>) {
# skip header if required.
if ($i < $_[3]) { $i++; next; }
chomp;
my @items = map {s/^\s+|\s+$//g; $_;} split ($_[1]);
# trim extra white-spaces
$_ =~ s/\s+/ /g;
$_ =~ s/^\s+|\s+$//g;
my @items = map { $_ } split ($_[1]);
my %iitems;
# use filter if required.
if ($items[0] =~ $_[2] && $_[2] ne "") {
Expand Down

0 comments on commit 7ebd548

Please sign in to comment.