Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UiApplication.cs #1082

Merged
merged 3 commits into from May 12, 2024
Merged

Update UiApplication.cs #1082

merged 3 commits into from May 12, 2024

Conversation

ricaun
Copy link
Contributor

@ricaun ricaun commented May 9, 2024

Ignore Application without Library Resources

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

If the Application.Current does not contain any Wpf.Ui; resource that application still is used , this PR checks the resources and ignore the Application that does not use Wpf.Ui;.

Issue Number: #1081

What is the new behavior?

By default nothing gonna change: if the MyApp\App.xaml have resources related to the Wpf.Ui library the Application.Current is used like before.

This PR only impact when the library is running outside of the desktop app context.

Other information

Ignore `Application` without LibraryResources
@ricaun ricaun requested a review from pomianowski as a code owner May 9, 2024 23:01
@github-actions github-actions bot added PR Pull request dotnet labels May 9, 2024
@pomianowski pomianowski merged commit 493d1e0 into lepoco:development May 12, 2024
2 checks passed
@ricaun
Copy link
Contributor Author

ricaun commented May 12, 2024

@pomianowski
Great 👏🏻
Would be amazing if you release or prerelease in the nuget a new version. 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet PR Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants