Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting stickynotes.py #3903

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from
Open

Conversation

XCaminhante
Copy link
Contributor

QMdiArea.SubWindowView became QMdiArea.ViewMode.SubWindowView at PyQt6
QMdiArea.TabbedView also became QMdiArea.ViewMode.TabbedView

QMdiArea.TabbedView also became QMdiArea.ViewMode.TabbedView
@XCaminhante XCaminhante changed the title stickynotes.py plugin patch about QMdiArea.ViewMode.* enum at Tabula class Correcting stickynotes.py May 9, 2024
@XCaminhante
Copy link
Contributor Author

XCaminhante commented May 9, 2024

Qt.WA_DeleteOnClose became Qt.WidgetAttribute.WA_DeleteOnClose
I flipped DeleteOnClose:False with DeleteOnClose:True, then added try-catches at the relevant places so the widget is recreated when necessary.

Also replaced self.mdi.removeSubWindow(i) with i.close(), so the widget frame don't became a ghost.

It is working as expected now, but I only manually tested

Now stickynote can grab notes when tabula is not visible
But there's a glitch, I need to call the command a second time
@XCaminhante
Copy link
Contributor Author

XCaminhante commented May 9, 2024

I removed the function blocking the widgets' onClose() events, I didn't see the need of it.
I also modified the stickynote command so it can steal notes from tabula when is not visible, but it's glitching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant