New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #286
Updates #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. Also, it may make sense to fix the size
issue in the same PR. The problem only occurs if every 8 hours or if you restart R.
rDNA/rDNA/R/rDNA.R
Outdated
#' labs ggtitle theme_bw theme arrow unit scale_shape_manual element_text | ||
#' scale_x_datetime scale_colour_manual guides | ||
#' scale_x_datetime scale_colour_manual guides rlang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is rlang
an object or function exported by ggplot2
? I thought it was an independent package. You need to add something like this to every function that uses .data
: @importFrom rlang .data
. I.e., also to the other autoplot methods that use this. Then recompile the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please fix as per my comments, then we'll see if it still produces errors (other than the ones I expect).
Let's try to wrap this PR up soon. Did you want to add anything else regarding |
All previous comments resolved. There is still an issue with autoplot function in dna_backbone. Here is the error log:
Backtrace:
The error occurs somewhere between lines 2851 and 2956. I checked all the geom_lines where "iteration" appears but cannot find anything odd. |
Thanks. I hope you can figure it out. Let me tag @TimHenrichsen . Tim, can you help? Kristijan fixed the |
Hi Kristijan and thanks for all the work! I could reproduce your issue and noticed that I also couldn't compute other autoplot functions. I checked the The .data pronoun is automatically created for you by data-masking functions using the tidy eval framework. You don't need to import rlang::.data or use library(rlang) to work with this pronoun. However, the .data object exported from rlang is useful to import in your package namespace to avoid a R CMD check note when referring to objects from the data mask. R does not have any way of knowing about the presence or absence of .data in a particular scope so you need to import it explicitly or equivalently declare it with utils::globalVariables(".data"). Note that rlang::.data is a "fake" pronoun. Do not refer to rlang::.data with the rlang:: qualifier in data masking code. Use the unqualified .data symbol that is automatically put in scope by data-masking functions. Could you test if the autoplot functions work, when you remove |
Dear @TimHenrichsen, thank you, it works now. It plots as supposed, but there are some warning messages that should be checked out:
This was ran on the sample example. Is something like that expected? Thank you for the help so far! |
The checks below say that you need to put |
Resolved. |
You forgot the comma in the line before. See new errors in the check log below. |
Comma added.
No description provided.