Skip to content

Commit

Permalink
Fixed a bug with dna_openConnectionProfile and a gradle bug
Browse files Browse the repository at this point in the history
  • Loading branch information
leifeld committed Jun 12, 2022
1 parent 1155940 commit e314bbf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dna/build.gradle
Expand Up @@ -59,7 +59,7 @@ dependencies {
// https://mvnrepository.com/artifact/org.slf4j/slf4j-api
implementation group: 'org.slf4j', name: 'slf4j-api', version: '2.0.0-alpha7'
// https://mvnrepository.com/artifact/org.slf4j/slf4j-nop
testImplementation group: 'org.slf4j', name: 'slf4j-nop', version: '2.0.0-alpha7'
implementation group: 'org.slf4j', name: 'slf4j-nop', version: '2.0.0-alpha7'
// https://mvnrepository.com/artifact/org.xerial/sqlite-jdbc
implementation group: 'org.xerial', name: 'sqlite-jdbc', version: '3.36.0.3'
// https://mvnrepository.com/artifact/org.swinglabs.swingx/swingx-all
Expand Down
6 changes: 5 additions & 1 deletion rDNA/R/rDNA.R
Expand Up @@ -169,7 +169,7 @@ dna_jar <- function() {
setwd(oldwd)
builtjar <- paste0(td, "/dna-master/dna/build/libs/dna-", v, ".jar")
if (file.exists(builtjar)) {
message("DNA source code downloaded and Jar file successfully built.")
message("DNA source code downloaded and jar file built successfully.")
}
}, error = function(e) {success <- FALSE})

Expand Down Expand Up @@ -499,6 +499,8 @@ dna_closeDatabase <- function() {
dna_saveConnectionProfile <- function(file, coderPassword = "") {
if (is.null(file) || !is.character(file) || length(file) != 1) {
stop("Please provide a file name for the connection profile.")
} else {
file <- normalizePath(file)
}
if (is.null(coderPassword) || !is.character(coderPassword) || coderPassword == "") {
if (!requireNamespace("askpass", quietly = TRUE)) {
Expand Down Expand Up @@ -562,6 +564,8 @@ dna_openConnectionProfile <- function(file, coderPassword = "") {
}
if (!file.exists(file)) {
stop("File does not exist.")
} else {
file <- normalizePath(file)
}
if (is.null(coderPassword) || !is.character(coderPassword) || coderPassword == "") {
if (!requireNamespace("askpass", quietly = TRUE)) {
Expand Down

0 comments on commit e314bbf

Please sign in to comment.