Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Srs improvement #317

Open
wants to merge 63 commits into
base: dev
Choose a base branch
from
Open

Srs improvement #317

wants to merge 63 commits into from

Conversation

flinkeKoralle
Copy link

If speed is selected while in SRS, mode reverts to OPEN CLB

Description of Changes

If speed knob is pulled in SRS TO mode, the mode reverts to OPEN CLB if FCU altitude is above current altitude.
A triple click sounds ( not implemented yet )

Screenshots (optional)

Bugs fixed (if any)

Checklist:

  • My changes follow the Contributing Guidelines.
  • My changes implement realistic features.
  • Please have a main Developer test my changes before merging.

Maximiliano Keller added 30 commits September 25, 2023 22:37
retrieve dep.elevation and print
fa08837
before dashes
8fa439d
accelAltFt
fa62575
created setAccelAlt func
69a96e8
clr key on init and perf/to working
81680b9
conform tour 6.10.23
e5ababe
split line for TOPERF page for thrred/accel
ec62e66
Accel/ThrRed working as tested
8f9d0a5
Merge branch 'dev' into mcdu-fmgc-merger
d870da7
corrected manual thr/acc alt with no depApt
110dcc0
introducing ga-accel and ga-thrRed variables
5a76df6
print accel/thrred accordingly
1e0a23c
ga accel/trhRed vars working- MCDU not correct
8636dca
trying to change fonrt size in perfga
6f8f999
cannot change fontsize prfga page
9e3f5c7
input in perfga almost working
6297d2e
check if acc > thrRed
d1fd0f0
round error corrected in acc/thrRed
ef04b86
Startpoint for GA Property insertion
7dc9b68
improved imput on perf-ga page
1e5ce33
setting fonts
f1f68ef
input on perf ga further improved
e243487
fadec thrRed changed in ga by variables
e482426
minor errors corrected
3bb92d0
adding comments
23dcd73
Minor change to test push request
ca2a482
testing a timer with FD1 button
67e28bd
default fcu alt set to 100 ft
9d8a7da
fcu alt selection for 1k position corrected
3db9d0b
finding FCU outputs
5dbc713
Maximiliano Keller added 26 commits December 21, 2023 13:27
working commit. adding spd window functionality
f97616a 
todo: implement close/open spd window in FCU.nas file, simplifying the a320.flightdeck.xml file
startpoint for new managed speed selection
f1544a8 
todo: remove custom.input.spdManaged -> not needed
managed speed stops by itself if not valid
not working to get back to selected
fdf1f26
interim: fms gets into selected when spd pushed
2f618cd 
todo: check when fcu-spd is reset to selected
fmgc logic and fcu working todo: fcu cleanup and spd window
f42e725
separation of mngd spd active and valid
1ea47e0 
todo: display correctly on fcu
show dashes and no dot when in done phase
working on fcu indication at startup
0e6ca1c 
todo: phase transition check (done phase)
and redundant variables
start to refine FCU spd window
8bc0210
selected spd on gnd inhibited
0e69688
mngSpd triggered by FDs on gnd
24ccf98
mng speed triggered by v2 on gnd
fcedd11 
TODO: mng spd triggered by to/mct
before SRS trigger
9f633b7
Managed speed on gnd as expected.
9dd59d5 
TODO: selected spd only after 5s airborne
sel spd inhibit until 5s after lift-off
b047e5d 
TODO: sel spd disarms on gnd at eng start
sel spd not poss. on gnd with engs running and fd on.
Merge branch 'FCU-Preselect' into SPD-Window
0fabe4f
Merge branch 'PERF-GA-Page-Accel/ThrRed-Input-correction' into SPD-Wi…
121b8a1 
…ndow
sel spd inhibit with one eng running
71a9b13
align on gnd
477f7b8 
TODO: spd push on gnd, if pos lost no mangd spd
FCU SPD window behaviour improved
bc2262c 
TODO: move Mach/Speed changeover to a property and activate via listener.
Cleaned up Managed Speed vars. Preparing to merge last redundant vars:
34d4605 
fmgc.Custom.Input.spdManaged has same functionality as fmgc.FMGCNodes.mngSpdActive
consolidated all managed speed into mngSpdActive, and spdWindowOpen
b69cd3f
removed unused "fmgcSpeedValid"
d9f26fe
SRS mode reversion when speed selected fixed
885c71c 
todo: it should only be possible if FCU alt > act. alt
Speed won't be selected if FCU alt < act. alt
b4f8572
Fixed logic to cover other cases
d3fc34b
Thrust reduction alt is changed, when GA phase is active
f0437e4
@Octal450
Copy link
Collaborator

Hi,
Circling back re the forum discussion

Is this the new request or the previous one? Just confirming for before I evaluate.

Regards,
Josh

@flinkeKoralle
Copy link
Author

Hi, Circling back re the forum discussion

Is this the new request or the previous one? Just confirming for before I evaluate.

Regards, Josh

Yes this is the request that implements all the ones before that.
I am working on a better fms-phase logic. But it's not ready yet.

I merged the latest dev branch with my latest code with no problems.
So this pull shouldn't make any problems.

@Octal450
Copy link
Collaborator

Hi thanks
About the fms phases, be advised that there is possibility I may need to rework this code in the future. I'm not sure yet, but also you may continue.

I will be with this request soon.

Kind Regards,
Josh

@flinkeKoralle
Copy link
Author

flinkeKoralle commented Mar 26, 2024 •
edited

Speeds and phases are deeply interconnected.

I will continue working on it. I will open a new pull request once it is ready for testing.

Greetings,
Maxi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flinkeKoralle @Octal450