Spd window #315
Open
Spd window #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 25, 2023 22:37
added 25 commits
December 2, 2023 23:25
todo: separate fcu selected speed and autoflight commanded speed
todo: spd adjust in managed gets fmgc speed instead of current
todo: fcu default spd is 0. should be 100.
todo: if FD1+2 off then revert to selected speed
todo: implement close/open spd window in FCU.nas file, simplifying the a320.flightdeck.xml file
todo: remove custom.input.spdManaged -> not needed managed speed stops by itself if not valid
todo: check when fcu-spd is reset to selected
todo: display correctly on fcu show dashes and no dot when in done phase
todo: phase transition check (done phase) and redundant variables
TODO: mng spd triggered by to/mct
TODO: selected spd only after 5s airborne
TODO: sel spd disarms on gnd at eng start sel spd not poss. on gnd with engs running and fd on.
TODO: spd push on gnd, if pos lost no mangd spd
TODO: move Mach/Speed changeover to a property and activate via listener.
|
That's a lot of changes, will need thorough testing. I can't promise a timeline on that right now but I'll add it to my list. Kind Regards, |
|
Hi Josh,
You can ask me about all the changes - I guess it is faster in some
cases.
One change that is very easy to see is the one in FCU.nas, the
ALTAdjust function.
It changes the behavior for the knob to the real one (round to nearest
1000 when selector set to 1000).
Another change was the separation of the thrust reduction at take off
and the one for the G/A.
(Set on PERFGA.nas file and preset as an Pin Option on the DLH.xml).
The biggest one was the behavior of the speed window.
I think there is still room for improvement, as the managed speed is
embedded in a loop.
I hope I can change the managed speed to fully event based
(setlisteners). But it is ok for now.
Latest, when more complex failures kick in, it would be easier to
implement the real behavior if conditions are not nested in a loop I
think.
I chose to improve the speed window behavior because I thought it would
be easy.
It turned out to be much more complex. But I learned a lot.
I saw the post with the autobrake problem.
I thought about implementing it, but I think it would be a lot of work,
because I would implement the full LGCIU modules and its signals.
At the moment I want to improve a little more the managed/selected
speed. And from there maybe a failure case.
Greetings back,
Max
…On Mon, 2024-02-05 at 09:02 -0800, Josh Davidson wrote:
That's a lot of changes, will need thorough testing.
I can't promise a timeline on that right now but I'll add it to my
list.
Kind Regards,
Josh
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
added 3 commits
February 20, 2024 11:39
fmgc.Custom.Input.spdManaged has same functionality as fmgc.FMGCNodes.mngSpdActive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed Window Preselection Function
Description of Changes
When in managed speed, rotating the speed selector knob will open the window for a certain time.
If this speed is pulled, than speed becomes selected, otherwise it returns to managed.
Also there is a difference between an open window with active managed speed (yellow dot) and just a closed window (dahes).
Furthermore selected speed is inhibited on ground, once engines are running.
Screenshots (optional)
Bugs fixed (if any)
FCU speed window
FCU altitude selection of 100/1000
Checklist:
ready for merge