Skip to content
This repository has been archived by the owner on Nov 18, 2019. It is now read-only.

Remove code which clears dataURL #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove code which clears dataURL #68

wants to merge 1 commit into from

Commits on Sep 26, 2017

  1. Remove code which clears dataURL 

    In using `angular-signature` we found that clicking on the signature pad repeatedly would cause it to clear out.  I tested the `signature_pad` demo and I couldn't reproduce it, but I could reproduce it reliably in the `angular-signature` demo.  Doing some debugging it seemed to come from the `timeout` in `updateModel`.  When I removed the `isEmpty` check (as in this PR) we found that the problem went away and we didn't see any adverse effects.

So we were wondering: what was that code intended to do, and is it still needed?
    @cheerfulstoic
    cheerfulstoic committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    e4b2cbd View commit details
    Browse the repository at this point in the history