feat: use monorepo queries #5343

edgarkhanzadian · 2024-05-03T13:42:53Z

Try out Leather build 832434e — Extension build, Test report, Storybook, Chromatic

Connected to this PR in monorepo: leather-wallet/mono#113

coderabbitai · 2024-05-13T13:07:17Z

Important

Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

64 files out of 121 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

edgarkhanzadian · 2024-05-20T14:10:22Z

This one is ready for review. Fix for failing tests is out for review in monorepo. Once that's merged I'll update the packages and it should fix the failing CI.

Other than that, codewise this PR is ready

fbwoolf · 2024-05-22T00:36:42Z

Sorry, I prob just really created a lot of conflicts for you with my last merge. If helps, I can rebase this for you?

edgarkhanzadian · 2024-05-22T09:06:26Z

@fbwoolf nope all good! Merged, thank you!

kyranjamie

Fantastic refactor work @edgarkhanzadian 👏🏼

fbwoolf · 2024-05-22T15:23:26Z

tests/mocks/mock-inscriptions.ts

@@ -1,8 +1,9 @@
-import { Inscription } from '@shared/models/inscription.model';
+// import { createInscription } from '@leather-wallet/models';


Can these commented out lines be removed?

fbwoolf

🚀

kyranjamie · 2024-05-23T09:25:51Z

src/app/app.tsx

+            org: GITHUB_ORG,
+            repo: GITHUB_REPO,
+            branchName: BRANCH_NAME,
+            localConfig: localConfig as any,


We don't need to make this change now, but think the remote config should be separate

You mean like a separate package or it should be extension specific?

pete-watters

Great work 🚀

edgarkhanzadian mentioned this pull request May 3, 2024

feat: tweak bitcoin queries for extension leather-wallet/mono#113

Merged

kyranjamie approved these changes May 20, 2024

View reviewed changes

kyranjamie self-requested a review May 20, 2024 13:57

edgarkhanzadian requested review from pete-watters, fbwoolf and alter-eggo May 20, 2024 14:10

edgarkhanzadian marked this pull request as ready for review May 20, 2024 14:10

edgarkhanzadian force-pushed the feat/use-monorepo-queries branch from 7a3a71c to a2b839a Compare May 20, 2024 14:28

kyranjamie approved these changes May 22, 2024

View reviewed changes

fbwoolf reviewed May 22, 2024

View reviewed changes

fbwoolf approved these changes May 22, 2024

View reviewed changes

kyranjamie reviewed May 23, 2024

View reviewed changes

edgarkhanzadian mentioned this pull request May 23, 2024

fix: asset contractId use inconsistencies #5427

Merged

edgarkhanzadian force-pushed the feat/use-monorepo-queries branch 2 times, most recently from 0735c8e to b5d0805 Compare May 23, 2024 13:05

edgarkhanzadian added this pull request to the merge queue May 24, 2024

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 24, 2024

feat: use bitcoin queries from monorepo + inscriptions from monorepo

832434e

edgarkhanzadian force-pushed the feat/use-monorepo-queries branch from cda6bee to 832434e Compare May 24, 2024 09:47

pete-watters approved these changes May 24, 2024

View reviewed changes

edgarkhanzadian added this pull request to the merge queue May 24, 2024

Merged via the queue into dev with commit 2f113fc May 24, 2024
28 of 30 checks passed

edgarkhanzadian deleted the feat/use-monorepo-queries branch May 24, 2024 11:42

pete-watters mentioned this pull request May 24, 2024

release/sip-10-send #5446

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use monorepo queries #5343

feat: use monorepo queries #5343

edgarkhanzadian commented May 3, 2024 •

edited by leather-bot

coderabbitai bot commented May 13, 2024 •

edited

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

edgarkhanzadian commented May 20, 2024

fbwoolf commented May 22, 2024

edgarkhanzadian commented May 22, 2024

kyranjamie left a comment

fbwoolf May 22, 2024

edgarkhanzadian May 23, 2024

fbwoolf left a comment

kyranjamie May 23, 2024

edgarkhanzadian May 23, 2024

pete-watters left a comment

		@@ -1,8 +1,9 @@
		import { Inscription } from '@shared/models/inscription.model';
		// import { createInscription } from '@leather-wallet/models';

feat: use monorepo queries #5343

feat: use monorepo queries #5343

Conversation

edgarkhanzadian commented May 3, 2024 • edited by leather-bot

coderabbitai bot commented May 13, 2024 • edited

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

edgarkhanzadian commented May 20, 2024

fbwoolf commented May 22, 2024

edgarkhanzadian commented May 22, 2024

kyranjamie left a comment

Choose a reason for hiding this comment

fbwoolf May 22, 2024

Choose a reason for hiding this comment

edgarkhanzadian May 23, 2024

Choose a reason for hiding this comment

fbwoolf left a comment

Choose a reason for hiding this comment

kyranjamie May 23, 2024

Choose a reason for hiding this comment

edgarkhanzadian May 23, 2024

Choose a reason for hiding this comment

pete-watters left a comment

Choose a reason for hiding this comment

edgarkhanzadian commented May 3, 2024 •

edited by leather-bot

coderabbitai bot commented May 13, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)