Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tsconfig update for tokens pkg #5227

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: tsconfig update for tokens pkg #5227

merged 1 commit into from
May 20, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Apr 12, 2024

Try out Leather build b69fb7dExtension build, Test report, Storybook, Chromatic

Updates token package, which required some changes to the tsconfig settings for it to be able to find the declaration files

Summary by CodeRabbit

  • Chores

    • Updated dependencies to enhance performance and compatibility.
  • Refactor

    • Improved text styling functions for better readability and consistency across web platforms.
  • Configuration Changes

    • Modified TypeScript settings to optimize module handling and resolution, improving the development process and app performance.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 540c349 and feb5da8.
Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
Files selected for processing (3)
  • package.json (1 hunks)
  • theme/typography.ts (1 hunks)
  • tsconfig.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • package.json
Additional comments not posted (4)
theme/typography.ts (2)

1-1: Updated import statement aligns with the new focus on web-specific typography.


5-5: Correct usage of getWebTextVariants in defining text styles.

tsconfig.json (2)

4-4: Change in module setting to "preserve" should help maintain module syntax during compilation. Ensure to verify its impact on the build process.


5-5: Change in moduleResolution to "Bundler" aims to enhance compatibility with specific bundlers. Verify compatibility with the project's bundler setup.

Copy link

coderabbitai bot commented May 10, 2024

Walkthrough

The recent updates encompass a version increment for a dependency, TypeScript configuration adjustments, and a refinement in typography function usage. These changes aim to improve module management, update dependencies, and enhance text styling capabilities within the project.

Changes

File(s) Summary of Changes
package.json Updated @leather-wallet/tokens from "0.0.14" to "0.0.15".
theme/.../typography.ts Replaced getExtensionTextVariants with getWebTextVariants in imports and function usage.
tsconfig.json Changed TypeScript module option to "preserve" and moduleResolution to "Bundler".

🐰✨
In the code's garden, changes bloom anew,
A version steps up, as old makes way for new.
From node to Bundler, paths we refine,
With text styles transformed, oh how they shine!
Hop along, dear code, in your elegant dance,
In every byte and bit, we find a chance.
🌟📜


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between feb5da8 and b69fb7d.
Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
Files selected for processing (3)
  • package.json (1 hunks)
  • theme/typography.ts (1 hunks)
  • tsconfig.json (1 hunks)
Files skipped from review due to trivial changes (2)
  • package.json
  • tsconfig.json
Additional comments not posted (2)
theme/typography.ts (2)

1-1: Correctly updated import to use getWebTextVariants.


5-5: Usage of getWebTextVariants in defineTextStyles is consistent with the new import.

Verification successful

The textStyles constant is correctly imported and integrated within the theme configuration in panda.config.ts. This confirms that the usage of getWebTextVariants in defineTextStyles is consistent and properly integrated.

  • panda.config.ts: textStyles is included in the theme configuration.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify integration of `textStyles` with other components.

# Test: Search for usage of `textStyles`. Expect: Proper integration without issues.
rg --type typescript $'textStyles'

Length of output: 68



Script:

#!/bin/bash
# Description: Verify integration of `textStyles` with other components.

# Test: Search for usage of `textStyles`. Expect: Proper integration without issues.
rg 'textStyles'

Length of output: 355



Script:

#!/bin/bash
# Description: Extract lines from `panda.config.ts` to review the usage of `textStyles`.

# Extract lines containing `textStyles` and their surrounding context for review.
rg -A 5 -B 5 'textStyles' panda.config.ts

Length of output: 667

@kyranjamie kyranjamie added this pull request to the merge queue May 20, 2024
Merged via the queue into dev with commit 9699d76 May 20, 2024
28 checks passed
@kyranjamie kyranjamie deleted the chore/upgrade-tokens branch May 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants