feat: add rpc-get-xpub method #5203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
feat/rpc-get-xpub
branch
from
2862ba1
to
b5a5c83
Compare
kyranjamie
force-pushed
the
feat/rpc-get-xpub
branch
from
b5a5c83
to
5fbb877
Compare
kyranjamie
requested review from
edgarkhanzadian,
fbwoolf,
pete-watters and
alter-eggo
fbwoolf
reviewed
Apr 15, 2024
| origin, | ||
| onUserApproveGetXpub() { | ||
| if (!tabId || !origin) { | ||
| logger.error('Cannot give app accounts: missing tabId, origin'); |
There was a problem hiding this comment.
This logged error doesn't seem to have the right message, was this just copied?
|
Adding link to original PR here for ref: #4958 |
fbwoolf
approved these changes
Apr 15, 2024
|
cc/ @mica000 @fabric-8 @markmhendrickson This is a good point to raise. Currently the UI for this looks the same, but we should explain to the user what sharing their xpub means. |
|
This is a new API, and not additional functionality for Let's capture in the APIs database in Notion and design an approval UX for this particular request, since I agree we need to indicate clearly what it means to the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of xpub pr