Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate LNSwap #4938

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

integrate LNSwap #4938

wants to merge 6 commits into from

Conversation

pseudozach
Copy link
Collaborator

fixes #4558

some open design/UX questions on this:

  • How to enable a swap LNBTC -> STX when LNBTC balance is 0 ?
  • How should we take an LN invoice input from the user in case of STX -> LNBTC ?
  • Should lnswap sdk return a transaction for leather to sign (similar to what Alex SDK does) or can I just return created swap data that includes the contract address, amount and contract call parameters and prepare the payment on leather repo lnswap related components?

@markmhendrickson
Copy link
Collaborator

@pseudozach thanks! Mind including a screen recording walkthrough of how this currently works?

@kyranjamie
Copy link
Collaborator

kyranjamie commented Feb 15, 2024

How to enable a swap LNBTC -> STX when LNBTC balance is 0 ?

Can you elaborate on this. How would you be able to swap in the first place if your balance is zero? Is that how it works?

Other questions are design related. Do we have designs for LNSwap specific swapping flows? Edit see them here.. Imagine we need to update these with the latter questions re accepting invoice etc.

@pseudozach
Copy link
Collaborator Author

How to enable a swap LNBTC -> STX when LNBTC balance is 0 ?

Can you elaborate on this. How would you be able to swap in the first place if your balance is zero? Is that how it works?

Other questions are design related. Do we have designs for LNSwap specific swapping flows? Edit see them here.. Imagine we need to update these with the latter questions re accepting invoice etc.

I meant if user wants to use some other way to pay a Lightning invoice and then receive STX in their leather wallet. how do we enable that? I noticed in the codebase if a balance is 0, it wont show up in the list of swap pairs.

also I'm still trying to find an alternative way to test this end to end since both bitcoin and stacks testnet are unusable. I'll try to have a demo on regtest - devnet soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate LNSwap into swap screen
3 participants