Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports demo to native VR API #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmarcos
Copy link

@dmarcos dmarcos commented Oct 8, 2014

Hi from Mozilla. This patch makes one of those demos use the VR native APIs in the browser.

You need to run the demo in one of the development builds:

http://vrhelloworld.com/builds/

<title>Transformation and display for head-mounted Leap Motion Controller</title>

<!-- note - the light grabbing doesn't work with r68 -->
<script src="//cdnjs.cloudflare.com/ajax/libs/three.js/r67/three.min.js"></script>
<script src="http://cdnjs.cloudflare.com/ajax/libs/three.js/r67/three.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be left as // for display within https iframes. Makes it harder for dev, I know :(

@pehrlich
Copy link
Contributor

pehrlich commented Oct 8, 2014

Tried a cursory test in FF - looks nice! I'm curious - would it be better to fall back to a THREE.js riftEffect if the APIs are not available? This would remove browser dependencies, at the cost of more complication (edge cases for the app dev to test, etc). Perhaps the idea is that anyone with a rift would be sure happy to upgrade their browser for VR web apps.

@pehrlich
Copy link
Contributor

pehrlich commented Oct 8, 2014

The two scripts - VREffect & VRControls - is the idea that they would be available somewhere as 3rd party libraries?

@dmarcos
Copy link
Author

dmarcos commented Oct 8, 2014

They’re already part of three.js

https://github.com/mrdoob/three.js/blob/master/examples/js/controls/VRControls.js

https://github.com/mrdoob/three.js/blob/master/examples/js/effects/VREffect.js

I have to update the link to the builds

Diego.

On Oct 7, 2014, at 10:28 PM, Peter Ehrlich notifications@github.com wrote:

The two scripts - VREffect VRControls - is the idea that they would be available somewhere as 3rd party libraries?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants