First GPOs guide draft #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GabrielaReyna
commented
May 7, 2024
•
GabrielaReyna
commented
- Fix Change /cheerpj-jnlprunner/ links to /cheerpj-jnlp-runner/ #80
Deploying labs-leaningtech-com with
|
| Latest commit: |
94d45ec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b177a82.labs-leaningtech-com.pages.dev |
| Branch Preview URL: | https://jnlp-runner-gpos.labs-leaningtech-com.pages.dev |
|
Tests are failing because of #80 |
bates64
requested changes
May 13, 2024
src/content/docs/cheerpj-jnlp-runner/04-guides/private-hosting-chrome.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/cheerpj-jnlp-runner/04-guides/private-hosting-chrome.mdx
Show resolved
Hide resolved
src/content/docs/cheerpj-jnlp-runner/04-guides/private-hosting-chrome.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/cheerpj-jnlp-runner/04-guides/private-hosting-chrome.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/cheerpj-jnlp-runner/04-guides/private-hosting-chrome.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/cheerpj-jnlp-runner/04-guides/private-hosting-chrome.mdx
Outdated
Show resolved
Hide resolved
|
I'm getting broken link errors, it is trying to map to the older cheerpj-jnlprunner url. Any ideas on how to fix this? |
Yep, this is a known issue #80 |
|
Commit 94d45ec could have "fix #80" in the commit message so GitHub knows to close the issue when it is merged. See https://docs.github.com/en/issues/tracking-your-work-with-issues/closing-an-issue. I'll edit the PR description instead in this instance |
|
Do we prefer that Stefano reviews this? If my changes were resolved I'm happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.