Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Page indexing issues #5460

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iArchitSharma
Copy link
Contributor

@iArchitSharma iArchitSharma commented Mar 22, 2024

image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Archit Sharma <archit8679@gmail.com>
@github-actions github-actions bot added area/blog New posts or new blog functionality area/events area/site-config labels Mar 22, 2024
createRedirect({ fromPath: "/cloud-native-management/gcp-diagram", toPath: "/cloud-native-management/generate-gcp-architecture-diagram", redirectInBrowser: true, isPermanent: true });
createRedirect({ fromPath: "/whiteboard", toPath: "/solutions/architecture-diagram", redirectInBrowser: true, isPermanent: true });
createRedirect({ fromPath: "/comments", toPath: "/cloud-native-management/meshmap/collaborate/peer-reviews", redirectInBrowser: true, isPermanent: true });
createRedirect({ fromPath: "/careers/company/legal/terms-of-service", toPath: "/company/legal/terms-of-service", redirectInBrowser: true, isPermanent: true });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this invalid link coming from? Can we correct this at source instead of redirecting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote, I searched for each of these links in our codebase, but none of them exist within our codebase. Therefore, these are external links from other websites

@vishalvivekm
Copy link
Member

Let's discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iArchitSharma 👍

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iArchitSharma will you please have another look at this site build error:

error "gatsby-plugin-meta-redirect" threw an error while running the onPostBuild lifecycle:

ENOTDIR: not a directory, open '/home/runner/work/layer5/layer5/public/products.html/index.html'

@sudhanshutech
Copy link
Member

@iArchitSharma is it completed? what about failing check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality area/events area/site-config
Development

Successfully merging this pull request may close these issues.

None yet

4 participants