Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Inter-page navigation #5077

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

ankushbhardwaj408
Copy link
Member

Description

This PR fixes #5068
Inter-page navigation on all pages of the Handbook has been smoothed out from abrupt behavior.
Notes for Reviewers

Old behaviour

old.mp4

New behaviour

new.mp4

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Oct 23, 2023

🚀 Preview for commit 790e9cc at: https://653643364c06bc266cb35c7d--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Hey @ankushbhardwaj408 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@ankushbhardwaj408
Copy link
Member Author

ankushbhardwaj408 commented Oct 23, 2023

@vishalvivekm @abhijeetgauravm I missed the meeting because I was out. Apologies. Please review my PR. appreciate your help.

@sudhanshutech
Copy link
Member

@ankushbhardwaj408 the transition not looking as smooth, you can see meshery docs how smooth that it is. Apply styling to get it smoother

@ankushbhardwaj408
Copy link
Member Author

@sudhanshutech Can you tell me where I can find the docs.meshery.io code base so that I can take a look at it and implement the work here.

@sudhanshutech
Copy link
Member

@sudhanshutech Can you tell me where I can find the docs.meshery.io code base so that I can take a look at it and implement the work here.

no i am just referring you to the behaviour not the approach because docs is in other language

@l5io
Copy link
Contributor

l5io commented Oct 28, 2023

🚀 Preview for commit 0e8a7b8 at: https://653cca232de5725ffbe6eeb7--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Hey @ankushbhardwaj408 Let's discuss this on website call tomorrow at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

Copy link
Member

@sandramsc sandramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushbhardwaj408 Thanks for your contribution, this fix to me looks good as it implements the smooth transition requested in the initial issue.
@sudhanshutech I see what you mean by having the transition match the smoothness which is in the meshery doc website, @ankushbhardwaj408 are you able to replicate this to maintain consistency throughout?

P.S It might be good to add this type of requirement to the issue description so the assignee knows what to expect before undertaking the task, as I understand the transition in meshery doc is written in a different language than that which this current PR is attempting to address?

@ankushbhardwaj408
Copy link
Member Author

Description

This PR fixes #5068 Inter-page navigation on all pages of the Handbook has been smoothed out from abrupt behavior. Notes for Reviewers

Old behaviour

old.mp4
New behaviour

new.mp4
Signed commits

  • Yes, I signed my commits.

Hi @sandramsc i am not able to replicate the beahviour. Some help would be appreciated. But I think it fixes the irregularity as shown in the video.

@ankushbhardwaj408
Copy link
Member Author

The main issue was in the id names given to the elements because some links do not have transition effects so I corrected the id names and now all have the same behavior.

@l5io
Copy link
Contributor

l5io commented Nov 4, 2023

🚀 Preview for commit dc4efc7 at: https://6546144662a9b26575df61a5--layer5.netlify.app

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushbhardwaj408 how are you making sure the smoothness here, i see only addition of -

@ankushbhardwaj408
Copy link
Member Author

@sudhanshutech I thought we were talking about links as if some links are behaving differently than others. But I understand your point. I will look into it.

@abhijeetgauravm
Copy link
Contributor

Hey @ankushbhardwaj408 Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Nov 8, 2023

🚀 Preview for commit 1f6d90b at: https://654b77bf7671831340086d6f--layer5.netlify.app

@ankushbhardwaj408
Copy link
Member Author

@sudhanshutech I tried to make scroll like meshery docs site but it is not working, I tried to use scroll smooth behavior but still it is not working.

@sudhanshutech
Copy link
Member

I think we are not getting here what we needed, @ankushbhardwaj408 i will recommend you to discuss this any website meet to get help

@abhijeetgauravm
Copy link
Contributor

Hey @ankushbhardwaj408 Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@leecalcote
Copy link
Member

Merge conflict.

@leecalcote
Copy link
Member

I think we are not getting here what we needed, @ankushbhardwaj408 i will recommend you to discuss this any website meet to get help

Good call, @sudhanshutech

@l5io
Copy link
Contributor

l5io commented Nov 16, 2023

🚀 Preview for commit 060b974 at: https://6555966c43d1113335045f56--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 17, 2023

🚀 Preview for commit e8cc4d5 at: https://65576e8b260bab286118587a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 19, 2023

🚀 Preview for commit c53518f at: https://655a32ad34e0764ce02c6d3e--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Hey @ankushbhardwaj408 Let's discuss this on website call today at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Nov 20, 2023

🚀 Preview for commit 1f93278 at: https://655b71f25b5dda1e48603ee2--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <ankushbhardwaj408@gmail.com>
@ankushbhardwaj408
Copy link
Member Author

// @vishalvivekm

@l5io
Copy link
Contributor

l5io commented Nov 20, 2023

🚀 Preview for commit 86bed8f at: https://655b757185bcee23f6790bf0--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 22, 2023

🚀 Preview for commit f1ba9ad at: https://655ddcc320c2130ff20f6e7c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 3, 2023

🚀 Preview for commit 1a390de at: https://656cb864cb669e26755bbfeb--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit 093a29b at: https://656d4e155dabd37edb7f3962--layer5.netlify.app

@ankushbhardwaj408
Copy link
Member Author

@vishalvivekm //

@l5io
Copy link
Contributor

l5io commented Dec 10, 2023

🚀 Preview for commit d240e06 at: https://6575ec61a8508d40e8ee53a1--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

LGTM.
@vishalvivekm 👀

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 17, 2024
@vishalvivekm vishalvivekm removed the issue/stale Issue has not had any activity for an extended period of time label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Transition of Inter page navigation should be smooth
9 participants