-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enforce formatting, go mod tidy #288
Conversation
f20019a
to
d8bf593
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to run these in a pre-commit hook and call the pre-commit hook in a GH action? Then we could get immediate, and skippable, feedback and use the same code for the CI build.
Yea, that'd probably be better - I didn't do it because I'm not a fan of pre-commit. But I can definitely make that change. |
29cccd0
to
a080532
Compare
a080532
to
af88429
Compare
Ok, refactored to be a pre-commit hook. |
Adds CI checks for:
gofmt
: important to ensure code is always formatted in the repogo mod tidy
: important to ensure deterministic dependenciesIt does this via
git/hooks/pre-commit
, which can also be installed viamake install-hooks
.