Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt4 Cleanup #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Qt4 Cleanup #38

wants to merge 4 commits into from

Conversation

a17r
Copy link

@a17r a17r commented Dec 8, 2020

Follow-up to #36.

  • Qt4 is unmaintained upstream for many years.
  • Support for <2.8.12 will soon be dropped from a future CMake version.

Unmaintained upstream for many years.

Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Support for <2.8.12 will soon be dropped from a future CMake version.
Easier reading if all dependencies are listed in root CMakeLists.txt.

Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Raises CMake minimum to 3.6 for IMPORTED_TARGET.

Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@drfiemost
Copy link

Now that Qt6 is out it would be time to merge this and move on (#40)
Is there someone still maintaining the project? @ben-xo ?

@ben-xo
Copy link
Member

ben-xo commented Oct 14, 2021

Heya. This project is looking for a new maintainer. From my point of view its purpose is to support the last fm desktop app, which is also lacking a maintainer. I'd be very happy to endorse your changes - I just have no real way to test them at the moment. If you can get the desktop client to build in the relevant environments, that would amazing. Otherwise maybe start a fork and we can consider reintegration at a later date

@a17r
Copy link
Author

a17r commented Oct 14, 2021

I'd say there is basically no environment left with the necessary packages to build lastfm-desktop, which is a consequence of still depending on Qt4+Qt4WebKit.

https://repology.org/project/lastfm/versions
https://repology.org/project/lastfm/versions

When this PR is merged, then for sure lastfm-desktop will be broken unless ported.

@drfiemost
Copy link

There is at least Clementine player that depends on this library and I have my own project which I'm currently porting to Qt6.
I can help testing the build and basic scrobbling API on Linux and Windows if needed.
Hope that someone could step up as maintainer.

@drfiemost
Copy link

I've added Qt6 support, along with a few fixes, it's available here
Went quite smooth, the only downside is that the functions returning QMap no longer support multiple values with the same key, for which a QMultiMap is required.
Now it needs some testing, especially on Mac OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants