Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated staging server and fix test for QT5 at Ubuntu 19.10 #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcgomes
Copy link

@pcgomes pcgomes commented Mar 10, 2020

Remove "staging" host if "--debug" is set. The host is wrong and setting it via "--debug" clashes with an application own debug

@drfiemost
Copy link

TestUrlBuilder stil fails after applaying this change:

********* Start testing of TestUrlBuilder *********
Config: Using QtTest library 5.15.2, Qt 5.15.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.3.1 20201218), unknown unknown
PASS   : TestUrlBuilder::initTestCase()
PASS   : TestUrlBuilder::encode(ascii)
PASS   : TestUrlBuilder::encode(ascii alphanumeric)
PASS   : TestUrlBuilder::encode(ascii with symbols)
PASS   : TestUrlBuilder::encode(ascii with last.fm-special symbols)
FAIL!  : TestUrlBuilder::no404(Air - Radio #1) Compared values are not the same
   Actual   (getResponseCode( url )): 301
   Expected (200)                   : 200
   Loc: [/mnt/devel/projects/liblastfm/build/tests/TestUrlBuilder.h(66)]
FAIL!  : TestUrlBuilder::no404(Pink Floyd - Speak to Me / Breathe) Compared values are not the same
   Actual   (getResponseCode( url )): 301
   Expected (200)                   : 200
   Loc: [/mnt/devel/projects/liblastfm/build/tests/TestUrlBuilder.h(66)]
FAIL!  : TestUrlBuilder::no404(Radiohead - 2 + 2 = 5) Compared values are not the same
   Actual   (getResponseCode( url )): 301
   Expected (200)                   : 200
   Loc: [/mnt/devel/projects/liblastfm/build/tests/TestUrlBuilder.h(66)]
FAIL!  : TestUrlBuilder::no404(Above & Beyond - World On Fire (Maor Levi Remix)) Compared values are not the same
   Actual   (getResponseCode( url )): 301
   Expected (200)                   : 200
   Loc: [/mnt/devel/projects/liblastfm/build/tests/TestUrlBuilder.h(66)]
FAIL!  : TestUrlBuilder::test404() Compared values are not the same
   Actual   (getResponseCode( QUrl("http://www.last.fm/404") )): 301
   Expected (404)                                              : 404
   Loc: [/mnt/devel/projects/liblastfm/build/tests/TestUrlBuilder.h(84)]
PASS   : TestUrlBuilder::cleanupTestCase()
Totals: 6 passed, 5 failed, 0 skipped, 0 blacklisted, 419ms
********* Finished testing of TestUrlBuilder *********

It seems all the URLs should be switched to https by default.

kdesysadmin pushed a commit to KDE/amarok that referenced this pull request Apr 12, 2024
liblastfm checks QCoreApplication::arguments() for "--debug". That's not
easy to avoid, so add a synonym debug flag "--debug-last-fm" which has identical
functionality in Amarok, but doesn't trigger the non-functional last.fm debug
mode.

This is not pretty, but it is pretty contained and makes reasonable last.fm
bughunting possible. Should lastfm/liblastfm#37 ever
get merged, this commit can be reverted, but that might not happen anytime soon
as the PR has been pending for 4 years and latest liblastfm release was almost
10 years ago.

BUG: 485415
pcgomes pushed a commit to pcgomes/amarok that referenced this pull request May 5, 2024
liblastfm checks QCoreApplication::arguments() for "--debug". That's not
easy to avoid, so add a synonym debug flag "--debug-last-fm" which has identical
functionality in Amarok, but doesn't trigger the non-functional last.fm debug
mode.

This is not pretty, but it is pretty contained and makes reasonable last.fm
bughunting possible. Should lastfm/liblastfm#37 ever
get merged, this commit can be reverted, but that might not happen anytime soon
as the PR has been pending for 4 years and latest liblastfm release was almost
10 years ago.

BUG: 485415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants