Added support for returning Inline in transformers (Issue #763) #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaIng
suggested changes
Nov 17, 2020
| res = self._call_userfunc_token(c) | ||
| else: | ||
| res = c | ||
| if type(res) is Inline: |
There was a problem hiding this comment.
bad style: isinstance should be used.
|
|
||
| def a(self, children): | ||
| return Inline('c', 'd') | ||
|
|
There was a problem hiding this comment.
Adding a test to test for a Token would be nice just in case we somehow break that in the future.
| @@ -15,9 +15,16 @@ class Discard(Exception): | |||
| """ | |||
| pass | |||
|
|
|||
| # Transformers | |||
| class Inline(object): | |||
| """When returning an Inline instance in a transformer callback, | |||
There was a problem hiding this comment.
Question: Will this make sure that it is added to the docs?
Anyway, an example would be nice, as well as pointing out to use it Inline(a, b, c) and not Inline((a,b,c)).
And it should be added to the stubs.
|
And this PR is certainly not complete as can be seen from comments on #763. (e.g. still missing for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.