Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logstash build error #3353

Merged
merged 1 commit into from Mar 29, 2023
Merged

Fix logstash build error #3353

merged 1 commit into from Mar 29, 2023

Conversation

amber-lab
Copy link
Contributor

@amber-lab amber-lab commented Feb 12, 2023

Description

Logstash Dockerfile tries to install an already bundled plugin and returns an error while building.

Motivation and Context

This changes fixes issue #3173.
The path to the solution

Types of Changes

  • Bug fix (non-breaking change which fixes an issue).

Definition of Done Checklist:

  • I've read the Contribution Guide.
  • I enjoyed my time contributing and making developer's life easier :)

@amber-lab amber-lab changed the title Fix logstash build error Fix #3173 logstash build error Feb 12, 2023
@amber-lab amber-lab changed the title Fix #3173 logstash build error Fix logstash build error Feb 12, 2023
@makowskid
Copy link
Contributor

@Mahmoudz error still exists, please merge this fix

@amber-lab
Copy link
Contributor Author

@Mahmoudz error still exists, please merge this fix

Do this changes work for you?

@amber-lab amber-lab closed this Mar 28, 2023
@amber-lab amber-lab reopened this Mar 28, 2023
@makowskid
Copy link
Contributor

@Mahmoudz error still exists, please merge this fix

Do this changes work for you?

yes, they do

@makowskid
Copy link
Contributor

that line in is obsolete already with the new version of logstash so you can safely merge this fix

@bestlong bestlong merged commit 807c5d2 into laradock:master Mar 29, 2023
34 checks passed
@amber-lab amber-lab deleted the logstash_jdbc branch March 30, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants