Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppeteer Support (for Spatie/BrowserShot) #3245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamShady
Copy link

@JamShady JamShady commented Jul 21, 2022

Description

Adds Puppeteer + Chromium support (along with relevant/necessary dependencies, i.e. node, npm, etc) to the workspace and php-fpm containers

Motivation and Context

Allows PDF generation with Spatie/BrowserShot, which (in the current release) uses Chromium + Puppeteer to load a page and save as PDF.

Types of Changes

  • [] Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

  • I've read the Contribution Guide.
  • I've updated the documentation. (refer to this for how to do so).
  • I enjoyed my time contributing and making developer's life easier :)

@JamShady JamShady force-pushed the pr/puppeteer branch 3 times, most recently from d97cba3 to dc2dec7 Compare July 22, 2022 10:25
@shubhamchugh
Copy link

code working fine please merge it with the master branch

@shubhamchugh
Copy link

hi @JamShady

I tried this code now but not working giving issues.

browsershot not working

Error:
Could not find Chromium (rev. 1083080). This can occur if either 1. you did not perform an installation before running the script (e.g. npm install) or 2. your cache path is incorrectly configured (which is: /var/www/.cache/puppeteer). For (2), check out our guide on configuring puppeteer

Please help

@JamShady JamShady force-pushed the pr/puppeteer branch 2 times, most recently from 256dda0 to c59013f Compare September 20, 2023 10:15
@shubhamchugh
Copy link

@JamShady
Thanks for the update will try with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants