Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/xdebug 3 compatibility #3236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brnathanlima
Copy link

@brnathanlima brnathanlima commented Jul 3, 2022

Description

Updating xDebug .ini files in php-fpm and workspace folders to make them compatible with xDebug 3. Also changing default php-fpm xDebug environment variable (PHP_FPM_XDEBUG_PORT) in .env-example from 9003 to 9000 since xDebug changed the default port that it connects to the client for 9003.

More information about upgrading xDebug from version 2 to 3 can be foud in the upgrade guide from their website: https://xdebug.org/docs/upgrade_guide

Motivation and Context

Building PHP-FPM using php version 8 or 8.1 caused the following outputs in the console:
Xdebug: [Config] The setting 'xdebug.profiler_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.profiler_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) Xdebug: [Config] The setting 'xdebug.profiler_output_dir' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.profiler_output_dir (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) Xdebug: [Config] The setting 'xdebug.remote_autostart' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_autostart (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) Xdebug: [Config] The setting 'xdebug.remote_connect_back' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_connect_back (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) Xdebug: [Config] The setting 'xdebug.remote_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) Xdebug: [Config] The setting 'xdebug.remote_host' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_host (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) Xdebug: [Config] The setting 'xdebug.remote_mode' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_mode (See: https://xdebug.org/docs/errors#CFG-C-CHANGED) Xdebug: [Config] The setting 'xdebug.remote_port' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_port (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue).
    New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

  • I've read the Contribution Guide.
    I've updated the documentation. (refer to this for how to do so).
  • I enjoyed my time contributing and making developer's life easier :)

@PaolaRuby
Copy link
Contributor

Duplicate of #3206

Also, why??

-xdebug.idekey=PHPSTORM
+xdebug.idekey=VSCODE

@brnathanlima
Copy link
Author

Duplicate of #3206

Also, why??

-xdebug.idekey=PHPSTORM
+xdebug.idekey=VSCODE

Don't know if not touching the xdebug.ini files can make it compatible with xDebug 3.

Changing the idekey was a mistake cause I use VSCODE as primary IDE. I'm gonna change it back to PHPSTORM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants