power up certbot to be able to issue certificates to multiple domains with dry-run capabilities #2997
+60
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
#2729 (comment)
#2889
Motivation and Context
these changes enable fix several errors including:
Type: unauthorized
error: this was usually due to missing- ./certbot/letsencrypt/:/var/www/letsencrypt
volume mapping on nginx service which is now fixedChanges Made
certbot_1 | cp: cannot stat '/etc/letsencrypt/archive/app.test/cert1.pem': No such file or directory
/var/certs/"$CN"-cert1.pem
but now its/var/certs/$CN/cert.pem
Definition of Done Checklist: