Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power up certbot to be able to issue certificates to multiple domains with dry-run capabilities #2997

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ignatius-n
Copy link

Description

Fixes:
#2729 (comment)
#2889

Motivation and Context

these changes enable fix several errors including:

  1. nginx acme Type: unauthorized error: this was usually due to missing - ./certbot/letsencrypt/:/var/www/letsencrypt volume mapping on nginx service which is now fixed
  2. feature to test ssl certificate issuance: with the update you can now test certbot without the risk of hitting the all precious low production rate-limiting that will bur you from requesting additional certificates for at least 1 week.
  3. ability to request multi-domain certificates: it was a challenge requesting ssl certificates for multiple domains at once eg abc.com,xyz.info,fake.com at the same time. Right now you can easily achieve this by comma separating all your desired domains and certificates will be generated for each one of them

Changes Made

  • Bug fix (Secure Nginx with Let's Encrypt Guide #2889 and CertBot No such file or directory #2679) that was arising during coping of generated certificates. It looked something like
    certbot_1 | cp: cannot stat '/etc/letsencrypt/archive/app.test/cert1.pem': No such file or directory
  • New feature (ability to run certbot in test mode i.e dry-run).
  • New feature (ability to request ssl certificates for multiple domains at the same time).
  • Breaking change (there is a tiny change on where and how certificates are stored). Initially it was like for instance in /var/certs/"$CN"-cert1.pem but now its /var/certs/$CN/cert.pem

Definition of Done Checklist:

  • I've read the Contribution Guide.
  • I've updated the documentation. (refer to this for how to do so).
  • I enjoyed my time contributing and making developer's life easier :)

@Mahmoudz Mahmoudz force-pushed the master branch 15 times, most recently from 19793f6 to 483c8c3 Compare August 13, 2021 15:26
@Mahmoudz Mahmoudz force-pushed the master branch 12 times, most recently from 5503249 to 9707cb4 Compare August 13, 2021 16:05
@johnny-silverhand
Copy link

@ignatius-n thank you, is this already usable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants