use standardized host.docker.internal for docker host #2967
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes laradock#2966 where current versions of laradock containers are already making DNS requests to host.docker.internal which resolving NXDOMAIN when it should resolve. See docker/for-linux#264 moby/moby#40007 https://docs.docker.com/engine/release-notes/#networking-2 for docker-engine 20.10 Signed-off-by: Beau Hastings <beau@saweet.net>
Mahmoudz
force-pushed
the
master
branch
2 times, most recently
from
f031ded
to
5cf7449
Compare
Mahmoudz
force-pushed
the
master
branch
8 times, most recently
from
7a26bb5
to
471e699
Compare
Mahmoudz
force-pushed
the
master
branch
19 times, most recently
from
3b4c8ee
to
c06755d
Compare
Mahmoudz
force-pushed
the
master
branch
8 times, most recently
from
5503249
to
9707cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Containers are making DNS requests to host.docker.internal, but it does not resolve because laradock uses dockerhost instead.
Fixes #2966
Motivation and Context
Found this problem while debugging why unit tests ran slow when offline. The DNS requests were timing out because there is no local entry for host.docker.internal.
References:
Types of Changes
Definition of Done Checklist: