Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing redis.conf file is added for secured redis connection #1959

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ronydebnath
Copy link
Contributor

I completed the 3 steps below:
  • I've read the Contribution Guide.
  • I've updated the documentation. (refer to this for how to do so).
  • I enjoyed my time contributing and making developer's life easier :)

missing redis.conf file added to redis container. if merged this will fix #1954

@jasperf
Copy link
Contributor

jasperf commented Apr 4, 2019

Would also be nice if we could just curl or wget the latest one as we also grab the latest Redis. Now this configuration file will need replacing every now and then.

@ronydebnath
Copy link
Contributor Author

By default it will come with no password set to redis container and port bind to 127.0.0.1 but in laradock, the redis port is set to 'redis' , so pulling latest one is not a viable solution perhaps. see line no: 69 and 512 of redis.conf of this PR.

@jasperf
Copy link
Contributor

jasperf commented Apr 5, 2019

I think we can download it and then do a RUN command like

RUN   sed -i "s|some-original-string|the-new-string |g" redis.conf

as suggested here https://stackoverflow.com/a/27714071/460885 . And yes, running an sed sounds like an option post download to fix the address and to add a password. Password perhaps with variable set in docker-compose file. But not sure how to do that using sed with an .env file inside. Maybe someone else here does. Or else just set it with a default to be replaced later.

@ronydebnath
Copy link
Contributor Author

Your idea sounds good. I'll try something like that in my spare time.

@Mahmoudz Mahmoudz force-pushed the master branch 3 times, most recently from 7a26bb5 to 471e699 Compare July 31, 2021 13:42
@Mahmoudz Mahmoudz force-pushed the master branch 27 times, most recently from 5503249 to 9707cb4 Compare August 13, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants