feat: allow loading language-* module as plugins in application #9447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many language modules LanguageTool project provided. It is benefitical that langaugetool allow language-* module to be loaded dynimically before calling languagetool core functions. Currently language list is built in static context. This is proposal that the creation of languages list is happended when requested. This allows application to load language-* modules after its launch. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
An enhancement is requested in application, OmegaT project https://sourceforge.net/p/omegat/feature-requests/1714/ |
…nguage-modules Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/allow-dynamic-loadings-of-language-modules
branch
from
bcb07d0
to
d94b567
Compare
miurahr
commented
Nov 20, 2023
| @@ -283,7 +285,7 @@ public static Language getLanguageForLocale(Locale locale) { | |||
| return firstFallbackLanguage; | |||
| } | |||
| } | |||
| for (Language aLanguage : languages) { | |||
There was a problem hiding this comment.
Why getLanguageForLocale(Locale locale) exclude dynamic language module?
miurahr
commented
Nov 20, 2023
| @@ -42,11 +42,8 @@ public final class Languages { | |||
| private static final String PROPERTIES_KEY = "languageClasses"; | |||
| private static final Language NOOP_LANGUAGE = new NoopLanguage(); | |||
|
|
|||
| private static final List<Language> languages = getAllLanguages(); | |||
| private static final List<Language> dynLanguages = new ArrayList<>(); | |||
There was a problem hiding this comment.
dynLanguages updated but never read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many language modules LanguageTool project provided. It is benefitical that langaugetool allow language-* module to be loaded dynimically before calling languagetool core functions.
Currently language list is built in static initialization context.
This is a proposal that the creation of languages list is happened when requested. This allows applications to load language-* modules after a launch of the application, aka. classLoader load them after static initialization.