issue #92 do not use config for Xdebug 2 (outdated - causes problems in xdebug3 eg on php 8.1) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for xdebug 2 since current php-versions come with xdebug3
👷 Deploy request for lando-php pending review.Visit the deploys page to approve it
|
zuernBernhard
changed the title
|
The build issues with the php 8.3 image should be unrelated to your changes, but would be awesome to figure out what's going on there. Probably related to the failure in #93, although it's interesting that apache fails here. General comment, but shouldn't we leave in the xdebug 2 config (maybe adding a comment), since older versions of PHP will be still using xdebug 2 and will need that config? |
|
I agree that we shouldn't remove this. Older PHP images with Xdebug 2 use this same config file so removing the older config would break those. The more correct solution is probably to have separate configs for the different versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for xdebug 2 since current php-versions come with xdebug3