Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compose): Fix compose file path resolution as it is copied into the lando config directory #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

florianPat
Copy link

Hey there,
to work with lando as a drop in replacement for docker-compose and the "compose" config feature, the paths to env_files, volume definitions and build contexts need to be resolved correctly. As the docker compose files get copied into the lando compose config directory, these paths change from the compose project directory. This pull request aims to resolve issue 3373, which explains this issue.
It creates a new docker compose routing method to use the docker compose config command to generate the config relative to the target directory (lando-dir/compose/project-name), so that every docker compose stack just works with lando (for an example, see this commit.
Moreover, the app_mount can be disabled globally for every service due to a top level app_mount config, and one does not have to disable it for every service.

I would love some feedback on this feature.

Thanks in advance,
Flo

Copy link

netlify bot commented Dec 6, 2023

👷 Deploy request for lando-core pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6503ba7

@reynoldsalec
Copy link
Sponsor Member

@florianPat thanks for taking a swing at this, looks interesting!

Note that I just got the tests are running with this repo's secrets, so you can use those to develop against if you're still interested in working on this. Thanks again!

@florianPat florianPat force-pushed the feature/issue-3373 branch 2 times, most recently from e885fe0 to 9d594c4 Compare March 13, 2024 07:39
@florianPat
Copy link
Author

Hey @reynoldsalec,
could you approve the workflows once again, so that I can develop against the tests?
I would love to finish this, as our team would benefit from this feature to adapt the lando tooling and not having to refactor the docker-compose files.

Thanks in advance,
Flo

@florianPat florianPat force-pushed the feature/issue-3373 branch 22 times, most recently from 652f88b to dbfde80 Compare March 22, 2024 15:44
@florianPat florianPat force-pushed the feature/issue-3373 branch 2 times, most recently from 9bb5b70 to 6da7cd2 Compare March 29, 2024 17:23
@florianPat
Copy link
Author

Hey @reynoldsalec,
it looks like the secrets do not get picked up by the action run. Could you look at it again?

Thanks in advance,
Flo

@florianPat florianPat force-pushed the feature/issue-3373 branch 3 times, most recently from 3c98137 to d139490 Compare April 8, 2024 20:58
@florianPat florianPat force-pushed the feature/issue-3373 branch 2 times, most recently from 9e086a5 to 990c4ec Compare April 22, 2024 14:40
lando directory and be able to set app mount user and use docker compose v2 seperator

Refs: lando/lando#3373
@lochmueller
Copy link

Looks very cool. That would be helpful for my projects...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants