fix(compose): Fix compose file path resolution as it is copied into the lando config directory #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
to work with lando as a drop in replacement for docker-compose and the "compose" config feature, the paths to env_files, volume definitions and build contexts need to be resolved correctly. As the docker compose files get copied into the lando compose config directory, these paths change from the compose project directory. This pull request aims to resolve issue 3373, which explains this issue.
It creates a new docker compose routing method to use the docker compose config command to generate the config relative to the target directory (lando-dir/compose/project-name), so that every docker compose stack just works with lando (for an example, see this commit.
Moreover, the app_mount can be disabled globally for every service due to a top level app_mount config, and one does not have to disable it for every service.
I would love some feedback on this feature.
Thanks in advance,
Flo