New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: breaking change policy #2324
Conversation
Tested in wjones127#3 |
release_process.md
Outdated
conventional commit markers: either exclamation mark after the type | ||
(such as `feat!: change signature of func`) or have `BREAKING CHANGE` in the | ||
body of the PR. A CI job will add a `breaking-change` label to the PR, which is | ||
what will ultimately be used to CI to determine if the minor version should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will ultimately be used to CI to determine if the minor version should be | |
what will ultimately be used by CI to determine if the minor version should be |
* Upgrading a dependency pin that is in the Rust API. In particular, upgrading | ||
`DataFusion` and `Arrow` are breaking changes. Changing dependencies that are | ||
not exposed in our public API are not considered breaking changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is only true if we are upgrading from one major version to another. However, given that has been the case for most releases of arrow and datafusion, I'm not sure it needs to be called out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on our definition of breaking change. For example if we change the pin from 40.0.0
to 40.0.1
, and a user has pinned =40.0.0
, we will have broken their build. But not really made a meaningful break change behavior wise I think.
@@ -0,0 +1,63 @@ | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool!
No description provided.