test: added nested field testcase for field of type list of ints #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Lance follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
nairajay2k
changed the title
|
if you just want to check whether nested list of int works, that should already be covered in lance test cases. thanks! |
|
lancedb/lancedb#899 has already been opened
for this.
…On Mon, Feb 12, 2024 at 1:44 AM Chang She ***@***.***> wrote:
if you just want to check whether nested list of int works, that should
already be covered in lance test cases.
if the goal is to check scalar indices, i don't believe scalar indices are
enabled for list columns (cc @westonpace <https://github.com/westonpace>).
If you need to create an index, please feel free to open a feature request
github issue for that.
thanks!
—
Reply to this email directly, view it on GitHub
<#1939 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ6XWJ5N4INLF52QHQGBOELYTERC7AVCNFSM6AAAAABDDRJSOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA2TONBQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Regards
Ajay
8762803277
|
|
I think this is inspired by #1946, so I'm all for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: added another create table method with a field as list of ints