Simplify get_offset_value_reference and add unit tests
#1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
fmoletta
approved these changes
Mar 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
==========================================
- Coverage 97.12% 96.70% -0.43%
==========================================
Files 91 95 +4
Lines 37246 38166 +920
==========================================
+ Hits 36176 36907 +731
- Misses 1070 1259 +189 ☔ View full report in Codecov by Sentry. |
pefontana
requested changes
Apr 17, 2024
| @@ -165,10 +165,6 @@ fn get_offset_value_reference( | |||
| apply_ap_tracking_correction(vm.get_ap(), var_ap_trackig, hint_ap_tracking)? | |||
| }; | |||
|
|
|||
| if offset.is_negative() && base_addr.offset < offset.unsigned_abs() as usize { | |||
There was a problem hiding this comment.
Why are we deleting this check?
There was a problem hiding this comment.
Because the logical test on base_addr and offset to know if we should return null is implicitly already provided by the Relocatable addition in the last step of the get_offset_value_reference function, so that I don't think it's needed is as an overhead.
|
This function no longer exists in the main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
get_offset_value_referenceand add unit testsDescription
base_addrandoffsetto know if we should return null is implicitly already provided by the Relocatable addition in the last step of theget_offset_value_referencefunction, so that I don't think it's needed is as an overhead.Description of the pull request changes and motivation.
Checklist