Fix token_to_integer to not require Copyable #670
Conversation
We can simply use a reference
| @@ -176,7 +176,7 @@ impl<'s> LowerState<'s> { | |||
|
|
|||
| read_algorithm(&grammar.annotations, &mut algorithm); | |||
|
|
|||
| let mut all_terminals: Vec<_> = self | |||
| let all_terminals: Vec<_> = self | |||
There was a problem hiding this comment.
@Destroyerrrocket As I understand, he is asking about the removed sort below.
There was a problem hiding this comment.
Yep, that sort caused problems while trying to match str&. Tbf, it's been a while and I don't remember all the details, but it gave me problems...
| @@ -19,7 +19,7 @@ macro_rules! return_err { | |||
| return Err(NormError { | |||
| message: format!($($args),+), | |||
| span: $span | |||
| }); | |||
| }) | |||
There was a problem hiding this comment.
Isn't there a compatibility warning about this?
There was a problem hiding this comment.
The original code makes warning. The changed one is fine.
This way the order of the match arms is preserved, otherwise some arms that are more general would be moved over more specific ones. |
|
In this issue I explained in detail what that sort does: |
|
Hmmm, could we split off the Copy restriction from the sorting to unblock bf55006? That seems like something easy to merge on its own. |
We can simply use a reference