Allow precedence annotations in macro defs #667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests allows for use of precedence annotations inside macro definitions:
This change has two essential parts:
<right:Expr<B>>
becomes<right:Expr0<B>>
It seems to work well, my only concern is how to handle substitution of macro arguments in the presence of associativity.
That is, what should we get when have:
Should it be
<right: Expr0<Expr<B>>
or<right: Expr0<Expr0<B>>
. In this PR we get the former.My suspicion is that substitution within macro args was already a bit wonky because associative replacement was done in a depth-first manner, skipping the first substitution. This meant that even prior to this change we'd have weird behavior like:
becomes:
So the situation was already messy, but now it's a little worse that the macro name is also a possible substitution. Curious what people's thoughts are.