Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue1386/use maven plugin to validate java version #2635

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Munandermaan
Copy link
Contributor

@Munandermaan Munandermaan commented Jan 20, 2020

Pull Request Checklist

Fixes

Fixes #1386

Purpose

Use maven-Enforcer-plugin to validate java -version

@Munandermaan Munandermaan requested a review from a team as a code owner January 20, 2020 13:02
@ihostage
Copy link
Contributor

@Munandermaan
For add enforced-plugin to hello-world-maven-archetype, need to change the next file https://github.com/lagom/lagom/blob/master/dev/archetypes/maven-java/src/main/resources/archetype-resources/pom.xml

@ihostage
Copy link
Contributor

But I think that we don't need to fix this issue. Because Lagom doesn't work with Java 11 only on DEV-Mode. And this problem will be fixed after integrating with Testcontainers for DEV-Mode.

@Munandermaan
Copy link
Contributor Author

@Munandermaan
For add enforced-plugin to hello-world-maven-archetype, need to change the next file https://github.com/lagom/lagom/blob/master/dev/archetypes/maven-java/src/main/resources/archetype-resources/pom.xml

Done

@Munandermaan
Copy link
Contributor Author

But I think that we don't need to fix this issue. Because Lagom doesn't work with Java 11 only on DEV-Mode. And this problem will be fixed after integrating with Testcontainers for DEV-Mode
@ihostage This may be like an extra feature to tell user about the java version

@ihostage
Copy link
Contributor

@ihostage This may be like an extra feature to tell user about the java version

Yes. But users can think that Lagom supports only Java 8 version, but it's not true 😄
How about the source and target Java version on compiler plugin?

@ignasi35 ignasi35 removed the request for review from a team April 6, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use Maven Enforcer Plugin to validate Java Version
2 participants