Pass initial configuration to additional configuration override. #2531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes #2448
Purpose
Allow
additionalConfiguration
access to the initial application configuration which it may override.Background Context
I had a use-case where I needed to reference values in the initial application configuration in order to implement my override logic. Currently this would require explicitly compiling the initial application configuration in the same way it is already compiled in
LagomApplication
inside of my additional configuration implementation. See #2448 for more details.This PR still requires documentation updates and test coverage. I would also like guidance on deprecation: should we allow both methods to exist? If not, what should be provided in
since
? I have stubbed it out with1.6.0
for now.