Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnyVal support for path parameters #1724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

golemiso
Copy link

@golemiso golemiso commented Feb 4, 2019

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you signed the Lightbend CLA?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Fixes #585

Purpose

To make it possible to use value class (AnyVal) as path parameters.

Background Context

Play 2.7.0 released and it supports value class as path parameters.
It is useful for lagom to support this feature.

References

PlayFramework's solution: playframework/playframework#8076

@golemiso golemiso changed the title Add AnyVal support as path parameters Add AnyVal support for path parameters Feb 5, 2019
@golemiso golemiso changed the title Add AnyVal support for path parameters [WIP] Add AnyVal support for path parameters Feb 5, 2019
@golemiso golemiso changed the title [WIP] Add AnyVal support for path parameters Add AnyVal support for path parameters Feb 7, 2019
@golemiso golemiso requested a review from a team as a code owner June 3, 2019 10:34
@golemiso golemiso force-pushed the pathparam-anyval branch 2 times, most recently from 62f2199 to 6ffdab8 Compare July 19, 2019 06:24
@ignasi35 ignasi35 removed the request for review from a team February 20, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Using a value class as a path parameter causes java.lang.IllegalArgumentException: argument type mismatch
2 participants