Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New photometric VS features + improvements to vpFeatureLuminance #1359

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

SamFlt
Copy link
Contributor

@SamFlt SamFlt commented Mar 27, 2024

This PR introduces new visual servoing features, taken from the papers of Eric Marchand and readapted from his code.

These features are PCA and DCT compressed representations of the luminance information.

In terms of implementation, new classes are introduced:

  • vpFeatureLuminanceMapping a visual servoing feature, which combines a vpFeatureLuminance object with a vpLuminanceMapping subobject. This is the feature that is given to vpServo
  • vpLuminanceMapping, a common interface for mappings that operate on luminance information. a map method computes a vector representation from the image. The inverse method, converts this vector back to an image, with some information loss. Finally, the interaction method computes the Jacobian, given the image, the compressed representation and the photometric Jacobian (computed beforehand by vpFeatureLuminance when used with the vpFeatureLuminanceMapping)
  • The vpLuminanceMapping interface has two implementations: vpLuminancePCA and vpLuminanceDCT. they can be used interchangeably in vpFeatureLuminanceMapping

Before this PR is complete, several things are lacking:

  • Encapsulate a Levenberg-Marquardt control law in a custom class.
  • Add weighting mask when computing the error in vpFeatureLuminance
  • Add an option to have a depth per pixel instead of considering that all 3D points are at an equal distance from the camera.

@SamFlt
Copy link
Contributor Author

SamFlt commented May 21, 2024

@fspindle,

If the CI is ok, this PR can be merged. I will write a followup PR to implement the remaining features when I have some time :)

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 83.13609% with 114 lines in your changes are missing coverage. Please review.

Project coverage is 45.86%. Comparing base (49772bb) to head (6564493).
Report is 31 commits behind head on master.

Files Patch % Lines
...s/src/visual-feature/vpFeatureLuminanceMapping.cpp 75.53% 68 Missing ⚠️
...sual-servoing/photometricMappingVisualServoing.cpp 80.00% 36 Missing ⚠️
.../visp3/visual_features/vpFeatureLuminanceMapping.h 62.50% 6 Missing ⚠️
...features/src/visual-feature/vpFeatureLuminance.cpp 77.77% 2 Missing ⚠️
...ual_features/test/feature/testLuminanceMapping.cpp 98.96% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
+ Coverage   45.60%   45.86%   +0.25%     
==========================================
  Files        1081     1086       +5     
  Lines      109136   109887     +751     
  Branches    18787    18876      +89     
==========================================
+ Hits        49775    50396     +621     
- Misses      59361    59491     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant