first version of Balmer implementation #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this module is the first draft of the implementation of p-winds for the Balmer alpha, beta, and gamma lines via Boltzmann distribution and Saha equation. The calculation of the opacity follows Wyttenbach et al. (2020). Questions that need to be addressed from this commit: -How do we calculate the electron density? -How do we integrate this model via the Voigt profile into p-winds' main framework. -Will we retrieve on each Balmer line separately? And if we combined the fit, how do we address the difference in continuum between the Balmer lines?
added Balmer.py module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this module is the first draft of the implementation of p-winds for the Balmer alpha, beta, and gamma lines via Boltzmann distribution and Saha equation. The calculation of the opacity follows Wyttenbach et al. (2020).
Questions that need to be addressed from this commit before it is usable:
-How do we calculate the electron density?
-How do we integrate this model via the Voigt profile into p-winds' main framework?
-How to we link the calculated opacity to the LOS calculation in p-winds
-Will we retrieve each Balmer line separately? And if we combined the fit, how do we address the difference in continuum between the Balmer lines?