Added some instructions and an optional password for authentication p… #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,6 +151,7 @@ def _refreshConnectionData(self): | |||
| reg = cxn.registry | |||
| p = reg.packet() | |||
| p.cd(REGISTRY_PATH) | |||
| p.dir(key = 'regcontent') | |||
There was a problem hiding this comment.
No space here, i.e. p.dir(key='regcontent')
|
To be honest, I don't really understand good security practices. @maffoo is it normal to store a password in memory as is done here? |
|
I removed the blank space. I tested it for backwards compatibility. Also, how do you handle your version numbers? Should I have bumped this from 1.1 to 1.2? |
|
Good question. It's backwards compatible, so bump the minor version number. |
|
Done. |
|
If it turns out you guys think it is better to remove the password from the registry, I can easily change this. I was sort of wondering the same thing you asked @maffoo but for our purposes, the email account being used is really just a burner account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urposes.