Fix asynchrony bugs in dc_rack_server.py #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -607,7 +605,7 @@ def state(self): | |||
|
|
|||
| def strState(self): | |||
| """Returns the channel state as a list of strings""" | |||
| s = list(self.state) | |||
| s = list(self.state()) # self.state is a method, not an attribute... | |||
|
The changes all look good except for that |
…t into changeLEDs method
|
I added the changes to the fix_dc_rack_server branch. Sorry for the delay, I've been caught up with finals. |
|
I say LGTM. However, I think we should get one from @zchen088 too since this is important and I think he's the real expert with this part of the system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DanielSank Thanks for taking the time to write up these notes. I followed your advice and separated the bug fixes from the new features. I must have added and subtracted a bunch of blank lines from this file as I modified it to suit our needs. In any case, I should have payed more attention to these changes when I submitted the initial pull request. I have a decent amount of experience with git, but I am fairly new to pull requests. Seems like a nice way of controlling what changes go into your master branch.