Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better support for airgap mode 'exists', secure rke2 token by default, allow setting rke2_node_name, implement local artifact download and push to remote fallback #203

Open
wants to merge 40 commits into
base: develop
Choose a base branch
from

Conversation

simonfelding
Copy link

Description

There's a bunch of stuff in this commit. I realize it could have been multiple pull requests. Sorry about that.

  • added better support for airgap mode 'exists' in rke2.yml
  • deprecate rke2_snapshooter spelling error
  • secure rke2 token by default
  • fix indent of registries config (broke with tls_no_verify set)
  • allow setting rke2_node_name as node name
  • split logical and to multiple lines for readability
  • made the role guess if server or agent based on group it belongs to
  • implement local artifact download and push to remote fallback
  • updated documentation to match

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

reset my local cluster entirely and ran each feature against it.

@MonolithProjects MonolithProjects changed the base branch from main to develop March 15, 2024 15:49
@MonolithProjects MonolithProjects self-assigned this Mar 15, 2024
@MonolithProjects
Copy link
Collaborator

Hi @simonfelding, please resolve the conflicts

paulfantom and others added 26 commits March 27, 2024 22:27
I noticed a few places in the repo where there were some misspellings.
This is a minor update to correct those instances.

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
The kubeconfig allows full access to the cluster, so it should be kept secure. Previously it was readable by everyone, now only by the user running Ansible.
@simonfelding
Copy link
Author

@MonolithProjects I fixed the conflicts, is it okay now?

@Duke1715
Copy link

Duke1715 commented May 6, 2024

@MonolithProjects Hi! When can we expect the merge? I found some interesting changes there for use that I would like to see in the master.

@simonfelding
Copy link
Author

@MonolithProjects Hi! When can we expect the merge? I found some interesting changes there for use that I would like to see in the master.

Maybe I should split it into multiple PRs, it got kind of large..

@MonolithProjects
Copy link
Collaborator

@MonolithProjects Hi! When can we expect the merge? I found some interesting changes there for use that I would like to see in the master.

Maybe I should split it into multiple PRs, it got kind of large..

Yeah... I think that's a good idea. Plus I see in this PR commits which are already in Master and this makes it harder to review. Please split it and I am sure I can find a time to check it 😉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet