Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote/client: support token with template RemotePlace #1208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nlabriet
Copy link
Contributor

Description
Using a template for RemotePlace is very useful to avoid repetition.
This change adds support for token, when LG_PLACE == + or +TOKEN.

      RemotePlace:
        name: !template $LG_PLACE

The role containing the !template $LG_PLACE will be used if no other match is found.

It's a first step, one can imagine supporting more complex patterns like (see #1194):

      RemotePlace:
        name: !template "$LG_PLACE-bbb"

Checklist

Partially fixes #1194

Signed-off-by: Nicolas Labriet <nlabriet@centralp.fr>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: +0.3 🎉

Comparison is base (acd4d43) 63.0% compared to head (d2f8e83) 63.3%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1208     +/-   ##
========================================
+ Coverage    63.0%   63.3%   +0.3%     
========================================
  Files         159     159             
  Lines       11683   11686      +3     
========================================
+ Hits         7365    7405     +40     
+ Misses       4318    4281     -37     
Impacted Files Coverage Δ
labgrid/remote/client.py 54.1% <100.0%> (+2.7%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structuring multiple boards in environment config
2 participants