Add sshfs exporter class #1130
Open
Add sshfs exporter class #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a class that allows tests to export a local directory to an exporter via sshfs. In order to prevent the exporter from being able to access any file that the user has permission for on the file system (which would allow it to read SSH keys for example), the SFTP server is run in an isolated container by default using podman, although this can be overridden to use docker or directly execute the SFTP server if the exporters are trusted. Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
jluebbe
requested changes
Apr 26, 2023
Comment on lines
+124
to
+130
|
|
||
| # | ||
| # SFTP server | ||
| # | ||
| FROM alpine:3.17 as labgrid-sftp-server | ||
|
|
||
| RUN apk add openssh-sftp-server |
There was a problem hiding this comment.
It seems that the podman in Ubuntu 22.04 tries to build the other targets as well, so this should be a different Dockerfile.
| from ..resource.common import Resource, NetworkResource | ||
|
|
||
|
|
||
| DEFAULT_SFTP_SERVER = "podman run --rm -i --mount type=bind,source={path},target={path} labgrid/sftp-server:latest usr/lib/ssh/sftp-server -e {readonly}" |
There was a problem hiding this comment.
Hmm, how do we want to tell the user that we expect this image to exist locally? Do we want to have a runtime check for the image or is documentation enough?
Comment on lines
+32
to
+34
| resource = attr.ib( | ||
| validator=attr.validators.instance_of(Resource), | ||
| ) |
There was a problem hiding this comment.
We might want to connect to an exporter for a specific resource (similar to ManagedFile) or to the target as well. So I'd prefer to pass host/port instead of a resource. That would mean passing a config separately as well.
@JoshuaWatt Do you see a downside?
Emantor
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a class that allows tests to export a local directory to an exporter via sshfs.
In order to prevent the exporter from being able to access any file that the user has permission for on the file system (which would allow it to read SSH keys for example), the SFTP server is run in an isolated container by default using podman, although this can be overridden to use docker or directly execute the SFTP server if the exporters are trusted.
Description
Checklist