Add support for removing remote files when no longer needed #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaWatt
force-pushed
the
managedfile-cleanup
branch
from
a84447c
to
ac749b8
Compare
Adds a cleanup_resource() procedure to ManagedFile that removes the file
if it is remote. In addition, a context manager has been added to make
using the class easier:
mf = ManagedFile(path, device)
with mf.remote_path(cleanup=True) as path:
# Use path as the remote path here
# File will be removed from the remote here
Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
Adds a cleanup parameter to the flashscriptdriver that removes the file when flashing is complete Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
The HTTPVideoDriver was accidentally put in the middle of the FlashScriptDriver documentation, so move it back together Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
JoshuaWatt
force-pushed
the
managedfile-cleanup
branch
from
ac749b8
to
e92b985
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1126 +/- ##
======================================
Coverage 63.2% 63.2%
======================================
Files 152 152
Lines 11429 11449 +20
======================================
+ Hits 7225 7243 +18
- Misses 4204 4206 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Could you explain why the tmpfiles.d suggestion in the "attention box" in the exporter docs does not work for you? |
Bastian-Krause
added
the
needs author info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Files controlled with
ManagedFilecan sometimes be quite large and consume a large amount of space on the exporter, potentially causing it to run out and fail tests. In these cases, it is preferred to transfer the files every time they are needed instead of keeping them around in the cache.This adds a new
cleanupAPI toManagedFileto allow the remote file to be cleaned up manually when no longer required. TheFlashScriptDriverhas been extended to support this new API as wellChecklist