-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate gene #205
base: dev
Are you sure you want to change the base?
Translate gene #205
Conversation
…hat are not modulo 3
MMseqs2 create db must be forced in mode 1. So in |
@@ -43,6 +135,29 @@ def write_gene_sequences_from_annotations(genes_to_write: Iterable[Gene], file_o | |||
file_obj.flush() | |||
|
|||
|
|||
def translate_genes(sequences: TextIO, tmpdir: Path, threads: int = 1, code: int = 11) -> Path: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very similar to "translate_with_mmseqs" in the "align" module, maybe we can replace the "translate_with_mmseqs" with this function as well to centralize "translation" in ppanggolin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you talked about it already, but removing genetic_codes.py is definitely a good idea if we don't use it anymore
Two things have been done here:
--genes_prot
option, which works like the other options in theppanggolin fasta
command.