Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RGP fasta outputs #202

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix RGP fasta outputs #202

merged 2 commits into from
May 17, 2024

Conversation

ggautreau
Copy link
Collaborator

@ggautreau ggautreau commented Mar 26, 2024

PPanGGOLiN erroneously wrote genes into a FASTA format from RGP according to their associated gene families (reported in #122 ). However, since RGPs are defined at the gene level, it leads to incorrect results, notably an overly high count of genes.
This PR corrects this issue.

@ggautreau ggautreau added the bug label Mar 26, 2024
@jpjarnoux jpjarnoux self-requested a review March 26, 2024 10:21
@jpjarnoux jpjarnoux self-assigned this Mar 26, 2024
@JeanMainguy JeanMainguy changed the title Fix issue #122 Fix RGP fasta outputs Mar 26, 2024
@axbazin axbazin merged commit 88a5ece into dev May 17, 2024
5 checks passed
@axbazin axbazin deleted the bug_fasta_rgp branch May 17, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants